tabId support to chrome.extensions.getViews()

extensions/renderer/extension_frame_helper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_EXTENSION_FRAME_HELPER_H_
 #define EXTENSIONS_RENDERER_EXTENSION_FRAME_HELPER_H_
 
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 24 matching lines @@
   ExtensionFrameHelper(content::RenderFrame* render_frame,
                        Dispatcher* extension_dispatcher);
   ~ExtensionFrameHelper() override;
 
   // Returns a list of extension RenderFrames that match the given filter
   // criteria. A |browser_window_id| of extension_misc::kUnknownWindowId
   // specifies "all", as does a |view_type| of VIEW_TYPE_INVALID.
   static std::vector<content::RenderFrame*> GetExtensionFrames(
       const std::string& extension_id,
       int browser_window_id,
-      ViewType view_type);
+      ViewType view_type,
+      int tab_id);

[Devlin, 2016/07/11 17:23:45]

for my OCD, I'd rather group similar parameter types together - so in this case,
have tab_id follow browser_window_id, and come before view_type.

[catmullings, 2016/07/12 18:13:48]

Done.

 
   // Returns the main frame of the extension's background page, or null if there
   // isn't one in this process.
   static content::RenderFrame* GetBackgroundPageFrame(
       const std::string& extension_id);
 
   // Returns true if the given |context| is for any frame in the extension's
   // event page.
   // TODO(devlin): This isn't really used properly, and should probably be
   // deleted.
@@ skipping 86 matching lines @@
   std::vector<base::Closure> document_load_finished_callbacks_;
 
   base::WeakPtrFactory<ExtensionFrameHelper> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionFrameHelper);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_EXTENSION_FRAME_HELPER_H_