Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2105023008: PPC/s390: [builtins] New frame type for exits to C++ builtins (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] New frame type for exits to C++ builtins Port 5febc27b5d17f14908d5e3c225bdb9b8a6b2df9a Original commit message: Prior to this commit, calls to C++ builtins created standard exit frames, which are skipped when constructing JS stack traces. In order to show these calls on traces, we introduce a new builtin exit frame type. Builtin exit frames contain target and new.target on the stack and are not skipped during stack trace construction. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4815 LOG=N Committed: https://crrev.com/3ee6b808a4326f2cd0140876cbd9c1e3c429761b Cr-Commit-Position: refs/heads/master@{#37461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -18 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M src/s390/builtins-s390.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/s390/macro-assembler-s390.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-30 21:09:35 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-06-30 21:52:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105023008/1
4 years, 5 months ago (2016-06-30 21:59:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 22:30:46 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 22:31:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ee6b808a4326f2cd0140876cbd9c1e3c429761b
Cr-Commit-Position: refs/heads/master@{#37461}

Powered by Google App Engine
This is Rietveld 408576698