Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2105023003: [turbofan] Also verify lazy bailout points in graph builder. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also verify lazy bailout points in graph builder. This adds verification of bailout IDs to {PrepareFrameState} to ensure all bailout points used for lazy deoptimization have been prepared by full codegen. This will catch bailout ID abuse during graph building instead of late in the deoptimizer. Similar verification for all eager deoptimization points is already present. R=jarin@chromium.org Committed: https://crrev.com/9e12b838aa9c3e7e672c70339253e2236214cf8f Cr-Commit-Position: refs/heads/master@{#37421}

Patch Set 1 #

Patch Set 2 : Fix count operation on super property. #

Patch Set 3 : Fix object literals with duplicate computed properties. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Starzinger
4 years, 5 months ago (2016-06-29 09:34:33 UTC) #1
Michael Starzinger
PTAL. I think I caught all fallout by now. Should be ready for prime time.
4 years, 5 months ago (2016-06-29 13:11:20 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-06-30 08:03:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2105023003/40001
4 years, 5 months ago (2016-06-30 08:30:57 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 08:33:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 08:35:25 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e12b838aa9c3e7e672c70339253e2236214cf8f
Cr-Commit-Position: refs/heads/master@{#37421}

Powered by Google App Engine
This is Rietveld 408576698