Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: src/runtime/runtime-wasm.cc

Issue 2105013004: Explicitly Disallow heap allocation when wasm memory references are updated (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-wasm.cc
diff --git a/src/runtime/runtime-wasm.cc b/src/runtime/runtime-wasm.cc
index 75e2a76b8b2965527828af6fee0c07e4be38f1f8..0817ff5854fc9d3815fbaf22fe01e12ba4e4fdd5 100644
--- a/src/runtime/runtime-wasm.cc
+++ b/src/runtime/runtime-wasm.cc
@@ -30,7 +30,7 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
Code* code = isolate->inner_pointer_to_code_cache()->GetCacheEntry(pc)->code;
ahaas 2016/06/29 07:13:31 Use also "the DisallowHeapAllocation no_allocation
gdeepti 2016/06/29 23:38:38 Thanks for clarifying that, used "DisallowHeapAllo
FixedArray* deopt_data = code->deoptimization_data();
DCHECK(deopt_data->length() == 2);
- JSObject* module_object = JSObject::cast(deopt_data->get(0));
+ Handle<JSObject> module_object(JSObject::cast(deopt_data->get(0)));
RUNTIME_ASSERT(!module_object->IsNull(isolate));
Address old_mem_start, new_mem_start;
« no previous file with comments | « no previous file | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698