Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 21050002: Move browsing data API functions registrations out of ExtensionFunctionRegistry (Closed)

Created:
7 years, 4 months ago by pals
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move browsing data API functions registrations out of ExtensionFunctionRegistry BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215006

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -126 lines) Patch
M chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 3 chunks +44 lines, -41 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 6 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 9 chunks +48 lines, -48 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pals
PTAL. Thanks
7 years, 4 months ago (2013-07-29 10:30:25 UTC) #1
not at google - send to devlin
thanks for splitting this up, need the nocompile though.
7 years, 4 months ago (2013-07-29 14:50:19 UTC) #2
pals
On 2013/07/29 14:50:19, kalman wrote: > thanks for splitting this up, need the nocompile though. ...
7 years, 4 months ago (2013-07-31 12:22:08 UTC) #3
not at google - send to devlin
lgtm
7 years, 4 months ago (2013-07-31 14:32:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/21050002/7001
7 years, 4 months ago (2013-08-01 05:52:03 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 11:56:20 UTC) #6
Message was sent while issue was closed.
Change committed as 215006

Powered by Google App Engine
This is Rietveld 408576698