Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 21050: POSIX: Backing store scrolling. (Closed)

Created:
10 years, 6 months ago by agl
Modified:
8 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

POSIX: Backing store scrolling. In the long term, we plan to get rid of all this code and "do things properly". However, for now we are implementing several shortcuts to get something which can render. Part one of this was BitmapWireData (r9065) which transported updates from the renderer over the IPC channel. This patch implements the fast-scrolling path, slowly. It might seem that this is something which Skia should be doing. However, copying from one bitmap to the same bitmap needs to be handled very differently from bitblitting from one to another to save writing to locations that you'll need to read from later on. I can't see any indication in the Skia code that it handles this case so, in order to get something working quickly, we write our own, small, bitblitter. Since this code hasn't been tested, it's almost certainly buggy. However, we don't get to test it until we get a little more of the browser up and running.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -2 lines) Patch
M chrome/browser/renderer_host/backing_store_posix.cc View 2 chunks +129 lines, -2 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
agl
10 years, 6 months ago (2009-02-04 19:10:29 UTC) #1
brettw
10 years, 6 months ago (2009-02-04 20:36:06 UTC) #2
I don't see any of the glaring bugs that inevitably will exist. LGTM

http://codereview.chromium.org/21050/diff/1/2
File chrome/browser/renderer_host/backing_store_posix.cc (right):

http://codereview.chromium.org/21050/diff/1/2#newcode39
Line 39: void BackingStore::ScrollRect(base::ProcessHandle process,
Can you make some comment that this is a temporary implementation until a "real"
one is implemented for each platform?

http://codereview.chromium.org/21050/diff/1/2#newcode129
Line 129: // scrolling down; dest rect is above src rect.
This comment and the next 3 need capital letters at the beginning.

Powered by Google App Engine
This is Rietveld 408576698