Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2104983002: Revert of GLContextGLX: try all GL versions from the highest. (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GLContextGLX: try all GL versions from the highest. (patchset #2 id:20001 of https://codereview.chromium.org/2098613004/ ) Reason for revert: Causes failures on the GPU FYI Linux Intel bot. Original issue's description: > GLContextGLX: try all GL versions from the highest. > > Also try all ES versions from the highest. This change will allow > Chrome to create a GL context higher than 3.0 on Mesa and will in turn > allow WebGL2 to run on Intel Linux when using the native GL driver. > > This patch is a direct port of the logic in ANGLE's DisplayGLX > > This is a reland of 3464004765597c914d8499ee9792cf81e106a4ae trying a > compatibility context first instead of a core context. (for non-Mesa > drivers) > > BUG=598902 > > Review-Url: https://codereview.chromium.org/1999543003 > Committed: https://crrev.com/3d090e4477520e14b782d2398e4a143982e189d4 > Cr-Original-Commit-Position: refs/heads/master@{#396243} > Cr-Commit-Position: refs/heads/master@{#402291} TBR=kbr@chromium.org,piman@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598902 Committed: https://crrev.com/b81ae31679859a887730a28a50228e416056ee78 Cr-Commit-Position: refs/heads/master@{#402461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -149 lines) Patch
M ui/gl/gl_context_glx.cc View 2 chunks +13 lines, -131 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Corentin Wallez
Created Revert of GLContextGLX: try all GL versions from the highest.
4 years, 5 months ago (2016-06-28 14:23:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104983002/1
4 years, 5 months ago (2016-06-28 14:23:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 14:24:33 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 14:26:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b81ae31679859a887730a28a50228e416056ee78
Cr-Commit-Position: refs/heads/master@{#402461}

Powered by Google App Engine
This is Rietveld 408576698