Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1126)

Issue 2104963002: Change CXFA_Node::GetClassName to return (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change CXFA_Node::GetClassName to return CXFA_Node::GetClassName currently takes an out parameter and returns void. This CL updates the signature to return the value and require no parameters. Committed: https://pdfium.googlesource.com/pdfium/+/017052a077d8f900e3098b8f9115078a037ee805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 4 chunks +8 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-06-28 13:52:36 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-06-28 14:43:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104963002/1
4 years, 2 months ago (2016-06-28 14:43:34 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-06-28 14:43:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/017052a077d8f900e3098b8f9115078a037e...

Powered by Google App Engine
This is Rietveld 408576698