Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2104943003: Add a useful DCHECK to RestoreCurrentTextureBindings. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a useful DCHECK to RestoreCurrentTextureBindings. BUG=624080 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/23ece3f89bebad856993492fd4d1e911d183dea4 Cr-Commit-Position: refs/heads/master@{#403929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
erikchen
zmo: Please review.
4 years, 5 months ago (2016-06-28 22:36:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104943003/1
4 years, 5 months ago (2016-06-28 22:38:42 UTC) #5
Zhenyao Mo
lgtm
4 years, 5 months ago (2016-06-28 22:51:20 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/247155)
4 years, 5 months ago (2016-06-29 00:21:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104943003/1
4 years, 5 months ago (2016-07-06 16:54:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 17:42:32 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 17:42:42 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:46:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23ece3f89bebad856993492fd4d1e911d183dea4
Cr-Commit-Position: refs/heads/master@{#403929}

Powered by Google App Engine
This is Rietveld 408576698