Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2104943002: Fix guard for UseMockKeyStorageForTesting (Closed)

Created:
4 years, 5 months ago by cfroussios
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix guard for UseMockKeyStorageForTesting https://codereview.chromium.org/2086123003/ introduced the possibility to either use Libsecret or KWallet. I'm updating a guard that I forgot to reflect the change. BUG=602624 Committed: https://crrev.com/fb11a7da3cae85b93c68a905077f458beecd0127 Cr-Commit-Position: refs/heads/master@{#402469}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/os_crypt/os_crypt.h View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cfroussios
Hi thestig! Can you review this small change? Thanks!
4 years, 5 months ago (2016-06-28 14:50:10 UTC) #2
Lei Zhang
lgtm
4 years, 5 months ago (2016-06-28 14:53:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104943002/20001
4 years, 5 months ago (2016-06-28 14:58:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 15:02:58 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:05:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fb11a7da3cae85b93c68a905077f458beecd0127
Cr-Commit-Position: refs/heads/master@{#402469}

Powered by Google App Engine
This is Rietveld 408576698