Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2104893006: Update V8 to version 5.3.336. (Closed)

Created:
4 years, 5 months ago by v8-autoroll
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 5.3.336. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/81ce7501..e1fa935d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/1a92fc945f648e9d787dda5c247cdfea088b6d65 Cr-Commit-Position: refs/heads/master@{#402773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
v8-autoroll
4 years, 5 months ago (2016-06-29 09:47:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104893006/1
4 years, 5 months ago (2016-06-29 09:47:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 11:03:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a92fc945f648e9d787dda5c247cdfea088b6d65 Cr-Commit-Position: refs/heads/master@{#402773}
4 years, 5 months ago (2016-06-29 11:05:02 UTC) #6
Sami
4 years, 5 months ago (2016-06-30 09:41:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2111853002/ by skyostil@chromium.org.

The reason for reverting is: Causing crashes on the perf waterfall (see bug for
logs):

 Received signal 11 SEGV_MAPERR 000000000010
        #0 0x7f3bf49793b7 base::debug::(anonymous
namespace)::StackDumpSignalHandler()
        #1 0x7f3bf46b9330 <unknown>
        #2 0x7f3bf0c84899 v8::internal::compiler::GraphTrimmer::TrimGraph()
        #3 0x7f3bf0ce9c8e
v8::internal::compiler::EffectControlLinearizationPhase::Run()
        #4 0x7f3bf0ce399b v8::internal::compiler::PipelineImpl::OptimizeGraph()
        #5 0x7f3bf0ce3904
v8::internal::compiler::PipelineCompilationJob::OptimizeGraphImpl()
        #6 0x7f3bf0c3acd8 v8::internal::CompilationJob::OptimizeGraph()
        #7 0x7f3bf0f6ec18
v8::internal::OptimizingCompileDispatcher::CompileNext()
        #8 0x7f3bf0f6f645
v8::internal::OptimizingCompileDispatcher::CompileTask::Run()
        #9 0x7f3bf49edaa7 base::(anonymous
namespace)::WorkerThread::ThreadMain()
        #10 0x7f3bf49e5b13 base::(anonymous namespace)::ThreadFunc()

BUG=624463.

Powered by Google App Engine
This is Rietveld 408576698