Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2104893004: Work around /analyze internal compiler error (Closed)

Created:
3 years, 3 months ago by brucedawson
Modified:
3 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews, Jeffrey Yasskin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around /analyze internal compiler error VS 2015 Update 3 fixes one internal compiler error, but hits another one when compiling Chrome. This CL works around the new internal compiler error by avoiding using a DCHECK (which uses __analysis_assume, which triggers the problem) when compiling for /analyze. _PREFAST_ is defined for all /analyze compiles. BUG=427616 Committed: https://crrev.com/9ca6e2937f3f435d527f601aeae2e220355d4155 Cr-Commit-Position: refs/heads/master@{#402910}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/time/time.h View 1 chunk +7 lines, -1 line 2 comments Download

Messages

Total messages: 11 (3 generated)
brucedawson
This is a bit ugly, but localized. The recent constexpr work on time.h helped to ...
3 years, 3 months ago (2016-06-29 00:03:39 UTC) #2
dcheng
LGTM with a nit/question https://codereview.chromium.org/2104893004/diff/1/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2104893004/diff/1/base/time/time.h#newcode671 base/time/time.h:671: #if !defined(_PREFAST_) || !defined(OS_WIN) Are ...
3 years, 3 months ago (2016-06-29 08:07:48 UTC) #3
brucedawson
> Are there non-Windows builds that define _PREFAST_? I figured that _PREFAST_ > would imply ...
3 years, 3 months ago (2016-06-29 17:46:12 UTC) #4
brucedawson
https://codereview.chromium.org/2104893004/diff/1/base/time/time.h File base/time/time.h (right): https://codereview.chromium.org/2104893004/diff/1/base/time/time.h#newcode671 base/time/time.h:671: #if !defined(_PREFAST_) || !defined(OS_WIN) On 2016/06/29 08:07:48, dcheng wrote: ...
3 years, 3 months ago (2016-06-29 17:47:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104893004/1
3 years, 3 months ago (2016-06-29 17:48:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 3 months ago (2016-06-29 19:52:08 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
3 years, 3 months ago (2016-06-29 19:52:54 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2016-06-29 19:54:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ca6e2937f3f435d527f601aeae2e220355d4155
Cr-Commit-Position: refs/heads/master@{#402910}

Powered by Google App Engine
This is Rietveld 408576698