Chromium Code Reviews| Index: chrome/browser/resources/chromeos/arc_support/background.js |
| diff --git a/chrome/browser/resources/chromeos/arc_support/background.js b/chrome/browser/resources/chromeos/arc_support/background.js |
| index f668037969f2da7f27ca2b052b2f6926f2690868..ac4b9905837cb87ea623972d447e26c375e5a8cd 100644 |
| --- a/chrome/browser/resources/chromeos/arc_support/background.js |
| +++ b/chrome/browser/resources/chromeos/arc_support/background.js |
| @@ -90,6 +90,7 @@ function initialize(data, deviceId) { |
| loadTimeData.data = data; |
| appWindow.contentWindow.i18nTemplate.process(doc, loadTimeData); |
| var countryCode = data.countryCode.toLowerCase(); |
| + setBackupRestoreMode(data.textBackupRestore, true); |
|
khmel
2016/06/28 23:09:54
Remove true? Ideally we should register listener o
malaykeshav
2016/06/29 01:29:06
Done.
Not sure what you mean by UMA impl. I have u
xiyuan
2016/06/29 21:36:38
khmel@ means is to observe the pref change:
https:
|
| var scriptSetCountryCode = 'document.countryCode = \'' + countryCode + '\';'; |
| termsView.addContentScripts([ |
| @@ -110,6 +111,17 @@ function initialize(data, deviceId) { |
| } |
| /** |
| + * Handles the event when the user clicks on a learn more link. Opens the |
| + * support page for the user. |
| + * @param {Event} event |
| + */ |
| +var onLearnMore = function(event) { |
| + var url = 'https://support.google.com/chromebook?p=playapps'; |
|
khmel
2016/06/28 23:09:54
Do we want the same help for both?
malaykeshav
2016/06/29 01:29:06
Yes. https://b.corp.google.com/u/0/issues/28704780
|
| + chrome.browser.openTab({'url': url}, function() {}); |
| + event.preventDefault(); |
| +}; |
| + |
| +/** |
| * Sets current metrics mode. |
| * @param {string} text Describes current metrics state. |
| * @param {boolean} canEnable Defines if user is allowed to change this metrics |
| @@ -127,21 +139,33 @@ function setMetricsMode(text, canEnable, on) { |
| event.preventDefault(); |
| }; |
| - var onLearnMore = function(event) { |
| - var url = 'https://support.google.com/chromebook?p=playapps'; |
| - chrome.browser.openTab({'url': url}, function() {}); |
| - event.preventDefault(); |
| - }; |
| - |
| doc.getElementById('text-metrics').innerHTML = text; |
| doc.getElementById('settings-link').addEventListener('click', onSettings); |
| - doc.getElementById('learn-more-link').addEventListener('click', onLearnMore); |
| + doc.getElementById('learn-more-link-metrics').addEventListener('click', |
| + onLearnMore); |
| // Applying metrics mode changes page layout, update terms height. |
| updateTermsHeight(); |
| } |
| /** |
| + * Sets current metrics mode. |
| + * @param {string} text String used to display next to checkbox. |
| + * @param {boolean=} isChecked Defines if backup and restore option is active |
|
khmel
2016/06/28 23:09:54
Not sure if '=' is needed.
malaykeshav
2016/06/29 01:29:06
No longer required.
|
| + * currently. By default the checkbox should be checked. |
| + */ |
| +function setBackupRestoreMode(text, isChecked) { |
| + var doc = appWindow.contentWindow.document; |
| + var enableBackupRestoreEl = doc.getElementById('enable-backup-restore'); |
| + enableBackupRestoreEl.checked = isChecked; |
| + enableBackupRestoreEl.hidden = false; |
|
khmel
2016/06/28 23:09:54
You always set it visible. I think this is not req
malaykeshav
2016/06/29 01:29:06
Done
|
| + |
| + doc.getElementById('text-backup-restore').innerHTML = text; |
| + doc.getElementById('learn-more-link-backup-restore').addEventListener('click', |
| + onLearnMore); |
| +} |
| + |
| +/** |
| * Updates terms view height manually because webview is not automatically |
| * resized in case parent div element gets resized. |
| */ |
| @@ -359,6 +383,12 @@ chrome.app.runtime.onLaunched.addListener(function() { |
| if (!enableMetrics.hidden && enableMetrics.checked) { |
| sendNativeMessage('enableMetrics'); |
| } |
| + |
| + var enableBackupRestore = doc.getElementById('enable-backup-restore'); |
| + if (enableBackupRestore.checked) { |
| + sendNativeMessage('enableBackupRestore'); |
| + } |
| + |
| sendNativeMessage('startLso'); |
| }; |