Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5562)

Unified Diff: chrome/browser/resources/chromeos/arc_support/background.js

Issue 2104893003: Adds a new checkbox for backup and restore in opt-in flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds a new checkbox for backup and restore in opt-in flow. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/arc_support/background.js
diff --git a/chrome/browser/resources/chromeos/arc_support/background.js b/chrome/browser/resources/chromeos/arc_support/background.js
index f668037969f2da7f27ca2b052b2f6926f2690868..da593ee1e397a0c4c212726e5594cfe0da2edb64 100644
--- a/chrome/browser/resources/chromeos/arc_support/background.js
+++ b/chrome/browser/resources/chromeos/arc_support/background.js
@@ -90,6 +90,7 @@ function initialize(data, deviceId) {
loadTimeData.data = data;
appWindow.contentWindow.i18nTemplate.process(doc, loadTimeData);
var countryCode = data.countryCode.toLowerCase();
+ setBackupRestoreMode(data.textBackupRestore, data.backupRestoreEnabled);
var scriptSetCountryCode = 'document.countryCode = \'' + countryCode + '\';';
termsView.addContentScripts([
@@ -110,6 +111,17 @@ function initialize(data, deviceId) {
}
/**
+ * Handles the event when the user clicks on a learn more link. Opens the
+ * support page for the user.
+ * @param {Event} event
+ */
+var onLearnMore = function(event) {
+ var url = 'https://support.google.com/chromebook?p=playapps';
+ chrome.browser.openTab({'url': url}, function() {});
+ event.preventDefault();
+};
+
+/**
* Sets current metrics mode.
* @param {string} text Describes current metrics state.
* @param {boolean} canEnable Defines if user is allowed to change this metrics
@@ -127,21 +139,31 @@ function setMetricsMode(text, canEnable, on) {
event.preventDefault();
};
- var onLearnMore = function(event) {
- var url = 'https://support.google.com/chromebook?p=playapps';
- chrome.browser.openTab({'url': url}, function() {});
- event.preventDefault();
- };
-
doc.getElementById('text-metrics').innerHTML = text;
doc.getElementById('settings-link').addEventListener('click', onSettings);
- doc.getElementById('learn-more-link').addEventListener('click', onLearnMore);
+ doc.getElementById('learn-more-link-metrics').addEventListener('click',
+ onLearnMore);
// Applying metrics mode changes page layout, update terms height.
updateTermsHeight();
}
/**
+ * Sets current metrics mode.
+ * @param {string} text String used to display next to checkbox.
+ * @param {boolean} isChecked Defines if backup and restore option is active.
+ */
+function setBackupRestoreMode(text, isChecked) {
elijahtaylor1 2016/06/30 04:52:34 nit: isChecked seems to indicate the current state
malaykeshav 2016/06/30 18:25:46 Renaming to defaultCheckValue
+ var doc = appWindow.contentWindow.document;
+ var enableBackupRestoreEl = doc.getElementById('enable-backup-restore');
+ enableBackupRestoreEl.checked = isChecked;
elijahtaylor1 2016/06/30 04:52:34 this could be a one-liner: doc.getElementById('en
malaykeshav 2016/06/30 18:25:46 Done
+
+ doc.getElementById('text-backup-restore').innerHTML = text;
+ doc.getElementById('learn-more-link-backup-restore').addEventListener('click',
+ onLearnMore);
+}
+
+/**
* Updates terms view height manually because webview is not automatically
* resized in case parent div element gets resized.
*/
@@ -356,9 +378,17 @@ chrome.app.runtime.onLaunched.addListener(function() {
var onAgree = function() {
var enableMetrics = doc.getElementById('enable-metrics');
- if (!enableMetrics.hidden && enableMetrics.checked) {
- sendNativeMessage('enableMetrics');
+ if (!enableMetrics.hidden) {
+ sendNativeMessage('enableMetrics', {
+ 'enabled': enableMetrics.checked
+ });
}
+
+ var enableBackupRestore = doc.getElementById('enable-backup-restore');
+ sendNativeMessage('setBackupRestore', {
+ 'enabled': enableBackupRestore.checked
+ });
+
sendNativeMessage('startLso');
};

Powered by Google App Engine
This is Rietveld 408576698