Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2104883002: Change text selection iterator behaviour for non-editable empty selection (Closed)

Created:
4 years, 5 months ago by MaheshMachavolu
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change text selection iterator behaviour for non-editable empty selection When the iterator that supports Image selection in editable fields is used in cases where there is empty selection, it still returns some non-empty character and hence makes a selection at empty areas too. Following commit: https://codereview.chromium.org/1845193002/ is causing this behaviour. So, in-order to maintain both use-cases, change iterator behavior to as it was previously for non-editable cases. BUG=623906 Committed: https://crrev.com/6e099723055362705266d6d4c70d4fdaa4c071c6 Cr-Commit-Position: refs/heads/master@{#402771}

Patch Set 1 #

Patch Set 2 : Added myself in AUTHORS list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
MaheshMachavolu
PTAL
4 years, 5 months ago (2016-06-28 11:42:27 UTC) #2
yosin_UTC9
lgtm
4 years, 5 months ago (2016-06-29 00:55:54 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 5 months ago (2016-06-29 03:08:22 UTC) #4
MaheshMachavolu
4 years, 5 months ago (2016-06-29 03:33:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104883002/20001
4 years, 5 months ago (2016-06-29 05:32:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/247393)
4 years, 5 months ago (2016-06-29 07:49:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104883002/20001
4 years, 5 months ago (2016-06-29 09:33:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 10:51:58 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 10:53:26 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e099723055362705266d6d4c70d4fdaa4c071c6
Cr-Commit-Position: refs/heads/master@{#402771}

Powered by Google App Engine
This is Rietveld 408576698