Handle fields with initializers in constant constructors.

Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an ErroneousConstantExpression for constants with compile time errors.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/95e6dde715e2164ba74a71d2f9924dd36f3d2266

Reverted: https://github.com/dart-lang/sdk/commit/fa8f7d20f3848db9676e8d1af30ceaefa1ccb21d
Committed: https://github.com/dart-lang/sdk/commit/ceb053a25777b57809913ba98a52f033099e07df

[Johnni Winther, 2016-06-29 10:42:21]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Johnni Winther, 2016-06-29 10:42:28]

Description was changed from

==========
Handle fields with initializers in constant constructors.

BUG=
==========

to

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.
==========

[Harry Terkelsen, 2016-06-30 16:39:03]

lgtm

https://codereview.chromium.org/2104843002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/2104843002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compile_time_constants.dart:736: if (receiverConstant ==
null && receiverConstant.isError) {
should be ||

[Johnni Winther, 2016-07-01 08:18:03]

https://codereview.chromium.org/2104843002/diff/20001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/2104843002/diff/20001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/compile_time_constants.dart:736: if (receiverConstant ==
null && receiverConstant.isError) {
On 2016/06/30 16:39:03, Harry Terkelsen wrote:
> should be ||

Thanks!

[Johnni Winther, 2016-07-01 08:22:15]

Description was changed from

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.
==========

to

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95e6dde715e2164ba74a71d2f9924dd36f3d2266
==========

[Johnni Winther, 2016-07-01 08:22:17]

Committed patchset #3 (id:40001) manually as
95e6dde715e2164ba74a71d2f9924dd36f3d2266 (presubmit successful).

[Johnni Winther, 2016-07-01 09:27:56]

Description was changed from

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95e6dde715e2164ba74a71d2f9924dd36f3d2266
==========

to

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95e6dde715e2164ba74a71d2f9924dd36f3d2266

Reverted:
https://github.com/dart-lang/sdk/commit/fa8f7d20f3848db9676e8d1af30ceaefa1ccb21d
==========

[Johnni Winther, 2016-07-01 10:37:04]

Description was changed from

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95e6dde715e2164ba74a71d2f9924dd36f3d2266

Reverted:
https://github.com/dart-lang/sdk/commit/fa8f7d20f3848db9676e8d1af30ceaefa1ccb21d
==========

to

==========
Handle fields with initializers in constant constructors.

This also normalizes CompileTimeConstantEvaluator to always create an
ErroneousConstantExpression for constants with compile time errors.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95e6dde715e2164ba74a71d2f9924dd36f3d2266

Reverted:
https://github.com/dart-lang/sdk/commit/fa8f7d20f3848db9676e8d1af30ceaefa1ccb21d
Committed:
https://github.com/dart-lang/sdk/commit/ceb053a25777b57809913ba98a52f033099e07df
==========

[Johnni Winther, 2016-07-01 10:37:06]

Committed patchset #5 (id:80001) manually as
ceb053a25777b57809913ba98a52f033099e07df (presubmit successful).

[Johnni Winther, 2016-07-01 10:37:47]

PTAL @ the last patch, post recommit.

[Harry Terkelsen, 2016-07-01 15:54:46]

lgtm