Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2104833002: Add strings for use in iOS update password infobar (Closed)

Created:
4 years, 5 months ago by Jackie Quinn
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@split_save_passwords
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add strings for use in iOS update password infobar Adds ios strings for the update password infobar, including strings for the buttons and strings for the label text. BUG=622244 Committed: https://crrev.com/3ed22f74673ed1e178ca2bd2ed5d3f5921ef9cb8 Cr-Commit-Position: refs/heads/master@{#402468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M ios/chrome/app/strings/ios_chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/ios_google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +15 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Jackie Quinn
4 years, 5 months ago (2016-06-28 09:09:30 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 5 months ago (2016-06-28 11:29:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104833002/1
4 years, 5 months ago (2016-06-28 13:40:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 15:01:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:03:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ed22f74673ed1e178ca2bd2ed5d3f5921ef9cb8
Cr-Commit-Position: refs/heads/master@{#402468}

Powered by Google App Engine
This is Rietveld 408576698