Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2104823002: Convert video-prefixed* and video-preload* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-prefixed* and video-preload* tests to testharness.js Cleaning up video-prefixed* and video-preload* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/6510fe630ff242a8d4337b718ed79db1c95e329a Cr-Commit-Position: refs/heads/master@{#402898}

Patch Set 1 : fix #

Total comments: 10

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -312 lines) Patch
M third_party/WebKit/LayoutTests/media/video-prefixed-fullscreen.html View 1 chunk +37 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-prefixed-fullscreen-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-preload.html View 1 1 chunk +57 lines, -146 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-preload-expected.txt View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-preload-none-no-stalled-event.html View 1 chunk +12 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-preload-none-no-stalled-event-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Srirama
PTAL
4 years, 5 months ago (2016-06-28 06:56:55 UTC) #4
fs
https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html File third_party/WebKit/LayoutTests/media/video-preload.html (right): https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html#newcode11 third_party/WebKit/LayoutTests/media/video-preload.html:11: { preload : "none", shouldBuffer : false, autoPlay : ...
4 years, 5 months ago (2016-06-28 08:56:42 UTC) #5
Srirama
https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html File third_party/WebKit/LayoutTests/media/video-preload.html (right): https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html#newcode22 third_party/WebKit/LayoutTests/media/video-preload.html:22: var movie = null; On 2016/06/28 08:56:42, fs wrote: ...
4 years, 5 months ago (2016-06-29 13:27:07 UTC) #6
fs
https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html File third_party/WebKit/LayoutTests/media/video-preload.html (right): https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html#newcode22 third_party/WebKit/LayoutTests/media/video-preload.html:22: var movie = null; On 2016/06/29 at 13:27:07, Srirama ...
4 years, 5 months ago (2016-06-29 13:35:18 UTC) #7
Srirama
https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html File third_party/WebKit/LayoutTests/media/video-preload.html (right): https://codereview.chromium.org/2104823002/diff/20001/third_party/WebKit/LayoutTests/media/video-preload.html#newcode11 third_party/WebKit/LayoutTests/media/video-preload.html:11: { preload : "none", shouldBuffer : false, autoPlay : ...
4 years, 5 months ago (2016-06-29 17:27:46 UTC) #9
fs
lgtm
4 years, 5 months ago (2016-06-29 17:52:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104823002/60001
4 years, 5 months ago (2016-06-29 18:10:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 5 months ago (2016-06-29 19:31:21 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:35:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6510fe630ff242a8d4337b718ed79db1c95e329a
Cr-Commit-Position: refs/heads/master@{#402898}

Powered by Google App Engine
This is Rietveld 408576698