Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2104813002: Fix a bug in user input detection for the site engagement service. (Closed)

Created:
4 years, 5 months ago by dominickn
Modified:
4 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, dominickn+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in user input detection for the site engagement service. Sites which lazy-load resources after navigating to the main frame do not trigger site engagement for user input. This CL fixes the bug by reordering when the input listening callbacks are stopped. BUG=623848 Committed: https://crrev.com/d014c1cfad770f6516556d5358f10f18e162096e Cr-Commit-Position: refs/heads/master@{#402753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/engagement/site_engagement_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dominickn
PTAL - this seems fine, because Start will only be called after WasShown() or at ...
4 years, 5 months ago (2016-06-28 05:25:22 UTC) #2
calamity
lgtm
4 years, 5 months ago (2016-06-29 07:27:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104813002/1
4 years, 5 months ago (2016-06-29 07:28:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 08:22:29 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 08:24:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d014c1cfad770f6516556d5358f10f18e162096e
Cr-Commit-Position: refs/heads/master@{#402753}

Powered by Google App Engine
This is Rietveld 408576698