Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Unified Diff: chrome/browser/resources/engagement/site_engagement.js

Issue 2104783002: Construct URLs from the url field when sorting site engagement by origin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/engagement/site_engagement.js
diff --git a/chrome/browser/resources/engagement/site_engagement.js b/chrome/browser/resources/engagement/site_engagement.js
index 6b94820ae3cf3cb662cfbdbf75aa0674880e04b9..ca27aec93739f2fe9188ff1f3aeed7923002548f 100644
--- a/chrome/browser/resources/engagement/site_engagement.js
+++ b/chrome/browser/resources/engagement/site_engagement.js
@@ -129,7 +129,7 @@ define('main', [
// Compare the hosts of the origin ignoring schemes.
if (sortKey == 'origin')
- return new URL(val1).host > new URL(val2).host ? 1 : -1;
+ return new URL(val1.url).host > new URL(val2.url).host ? 1 : -1;
if (sortKey == 'score')
return val1 - val2;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698