Issue 210473002: Merge 258106 "[Hotword] Making enabling/disabling the setting en..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210473002: Merge 258106 "[Hotword] Making enabling/disabling the setting en..." (Closed)

Created:
6 years, 9 months ago by rpetterson

Modified:
6 years, 9 months ago

Reviewers:
rpetterson

CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, chromium-apps-reviews_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

More Reviews

Description

Merge 258106 "[Hotword] Making enabling/disabling the setting en..." > [Hotword] Making enabling/disabling the setting enable/disable the hotword extension. > > This changes also allows external component extensions to be user modifiable. However, currently hotwording is the only such component which this affects since others are not typically accessible for changing. > > BUG=349573 > > Review URL: https://codereview.chromium.org/196753002 TBR=rlp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259016

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -7 lines)			Patch
M	chrome/browser/extensions/component_loader_unittest.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	2 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/browser/search/hotword_service.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/search/hotword_service.cc	View	4 chunks	+58 lines, -3 lines	0 comments	Download
M	chrome/browser/search/hotword_service_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	extensions/browser/admin_policy.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r259016.

Expand Messages | Collapse Messages