Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 21047008: Fix subpixel metrics with GDI. (Closed)

Created:
7 years, 4 months ago by bungeman-skia
Modified:
7 years, 4 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix subpixel metrics with GDI. The previous code uncovered a rather strange issue with GDI, where it appears that alternating between two HFONTs with the same attributes but vastly different heights does not appear to invalidate the the 'x' metrics (the 'y' metrics appear to be correct). As a result it is possible to get completely useless results from GetGlyphOutlineW. This change works around the issue by simply scaling the one font to the required sizes, which also saves us an HFONT. Committed: https://code.google.com/p/skia/source/detail?r=10425

Patch Set 1 #

Patch Set 2 : Move global now that there is one fewer user. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M src/ports/SkFontHost_win.cpp View 1 7 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
bungeman-skia
7 years, 4 months ago (2013-07-30 01:07:51 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r10425 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698