Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: ui/gfx/test/fontconfig_util_linux.cc

Issue 2104653002: Fix content shell layout test failure related to Fontconfig (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add call to FcConfigBuildFonts Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/test/fontconfig_util_linux.cc
diff --git a/ui/gfx/test/fontconfig_util_linux.cc b/ui/gfx/test/fontconfig_util_linux.cc
index 6f2da0be9c94017b8ad1330d9f53927b35e3ecd2..fd1ac563fa0ea142384a750f0f9ab00c91873761 100644
--- a/ui/gfx/test/fontconfig_util_linux.cc
+++ b/ui/gfx/test/fontconfig_util_linux.cc
@@ -72,9 +72,11 @@ void SetUpFontconfig() {
// - FcConfigReference() increments a config's refcount.
// - FcConfigDestroy() decrements a config's refcount, deallocating the
// config when the count reaches 0.
- // - FcConfigSetCurrent() calls FcConfigDestroy() on the old config, but
- // interestingly does not call FcConfigReference() on the new config.
- CHECK(FcConfigSetCurrent(FcConfigCreate()));
+ // - FcConfigSetCurrent() calls FcConfigDestroy() on the old config, and
+ // calls FcConfigReference() on the new config.
+ FcConfig* config = FcConfigCreate();
+ FcConfigBuildFonts(config);
+ CHECK(FcConfigSetCurrent(config));
Daniel Erat 2016/06/27 23:40:43 interesting. https://www.freedesktop.org/software/
}
void TearDownFontconfig() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698