 Chromium Code Reviews
 Chromium Code Reviews Issue 2104653002:
  Fix content shell layout test failure related to Fontconfig  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2104653002:
  Fix content shell layout test failure related to Fontconfig  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: ui/gfx/test/fontconfig_util_linux.cc | 
| diff --git a/ui/gfx/test/fontconfig_util_linux.cc b/ui/gfx/test/fontconfig_util_linux.cc | 
| index 6f2da0be9c94017b8ad1330d9f53927b35e3ecd2..fd1ac563fa0ea142384a750f0f9ab00c91873761 100644 | 
| --- a/ui/gfx/test/fontconfig_util_linux.cc | 
| +++ b/ui/gfx/test/fontconfig_util_linux.cc | 
| @@ -72,9 +72,11 @@ void SetUpFontconfig() { | 
| // - FcConfigReference() increments a config's refcount. | 
| // - FcConfigDestroy() decrements a config's refcount, deallocating the | 
| // config when the count reaches 0. | 
| - // - FcConfigSetCurrent() calls FcConfigDestroy() on the old config, but | 
| - // interestingly does not call FcConfigReference() on the new config. | 
| - CHECK(FcConfigSetCurrent(FcConfigCreate())); | 
| + // - FcConfigSetCurrent() calls FcConfigDestroy() on the old config, and | 
| + // calls FcConfigReference() on the new config. | 
| + FcConfig* config = FcConfigCreate(); | 
| + FcConfigBuildFonts(config); | 
| + CHECK(FcConfigSetCurrent(config)); | 
| 
Daniel Erat
2016/06/27 23:40:43
interesting. https://www.freedesktop.org/software/
 | 
| } | 
| void TearDownFontconfig() { |