MediaCaptureFromElement: add content_browsertests

MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc,
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data
flowing.

BUG=619926
TBR=emircan@chromium.org

Committed: https://crrev.com/c3bfd1da6fa3b657ecd6758a2da4fa09dd983781
Cr-Commit-Position: refs/heads/master@{#402923}

[mcasas, 2016-06-27 21:43:41]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-06-27 21:43:48]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-06-27 21:46:20]

Description was changed from

==========
MediaCaptureFromElement: add content_browsertests

BUG=619926
==========

to

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc, 
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test 
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a 
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data 
flowing.

BUG=619926
==========

[mcasas, 2016-06-27 22:26:58]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org, phoglund@chromium.org

[mcasas, 2016-06-27 22:26:59]

emircan@ PTAL
phoglund@ PTAL/RS plz

[phoglund_chromium, 2016-06-28 13:01:38]

Sorry, I'm out until july 5 or so, so I recommend finding another reviewer for
now.

[mcasas, 2016-06-28 14:35:48]

mcasas@chromium.org changed reviewers:
+ tommi@chromium.org

[mcasas, 2016-06-28 14:35:49]

tommi@ RS ISO phoglund please.

[tommi (sloooow) - chröme, 2016-06-29 07:52:37]

lgtm % minor things

https://codereview.chromium.org/2104643002/diff/40001/content/browser/media/w...
File content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc
(right):

https://codereview.chromium.org/2104643002/diff/40001/content/browser/media/w...
content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc:28: 
fix whitespace (will "git cl format" fix this?)

https://codereview.chromium.org/2104643002/diff/40001/content/browser/media/w...
content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc:71:
INSTANTIATE_TEST_CASE_P(,
missing name?

https://codereview.chromium.org/2104643002/diff/40001/content/test/data/media...
File content/test/data/media/video_audio_element_capture_test.html (right):

https://codereview.chromium.org/2104643002/diff/40001/content/test/data/media...
content/test/data/media/video_audio_element_capture_test.html:42: if
(recorded_events++ > NUMBER_OF_RECORDED_EVENTS)
nit: as is, due to using postfix, the condition is true when we've recorded
NUMBER_OF_RECORDED_EVENTS+1.

[mcasas, 2016-06-29 15:01:05]

Description was changed from

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc, 
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test 
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a 
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data 
flowing.

BUG=619926
==========

to

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc, 
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test 
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a 
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data 
flowing.

BUG=619926

TBR=emircan@chromium.org
==========

[mcasas, 2016-06-29 15:02:34]

Patchset #2 (id:60001) has been deleted

[mcasas, 2016-06-29 15:03:17]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-06-29 15:03:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2104643002/#ps80001
(title: "tommi@s nits")

[commit-bot: I haz the power, 2016-06-29 15:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 16:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 16:15:45]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mcasas, 2016-06-29 18:22:24]

Sending comments.

The new test fails on Android because of:

[INFO:CONSOLE(47)] "Failed to execute 'play' on
'HTMLMediaElement': API can only be initiated by
a user gesture."

Investigating.

https://codereview.chromium.org/2104643002/diff/40001/content/browser/media/w...
File content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc
(right):

https://codereview.chromium.org/2104643002/diff/40001/content/browser/media/w...
content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc:28: 
On 2016/06/29 07:52:37, tommi-chrömium wrote:
> fix whitespace (will "git cl format" fix this?)

I was curious: it didn't do it
(it only reindented l.64-67. So,
done manually.

https://codereview.chromium.org/2104643002/diff/40001/content/browser/media/w...
content/browser/media/webrtc/webrtc_capture_from_element_browsertest.cc:71:
INSTANTIATE_TEST_CASE_P(,
On 2016/06/29 07:52:37, tommi-chrömium wrote:
> missing name?

The first argument is an optional prefix [1]
and often not specified [2] so that the
test name (l.72) is the only one shown in
the output. For the curious, if stated like
INSTANTIATE_TEST_CASE_P(Bla,FooTest,...) the
output would be 
Bla/FooTest.TestCase/0
Bla/FooTest.TestCase/1
...


[1]
https://cs.chromium.org/chromium/src/testing/gtest/include/gtest/gtest-param-...

[2]
https://cs.chromium.org/search/?sq=package:chromium&type=cs&q=INSTANTIATE_TES...,

https://codereview.chromium.org/2104643002/diff/40001/content/test/data/media...
File content/test/data/media/video_audio_element_capture_test.html (right):

https://codereview.chromium.org/2104643002/diff/40001/content/test/data/media...
content/test/data/media/video_audio_element_capture_test.html:42: if
(recorded_events++ > NUMBER_OF_RECORDED_EVENTS)
On 2016/06/29 07:52:37, tommi-chrömium wrote:
> nit: as is, due to using postfix, the condition is true when we've recorded
> NUMBER_OF_RECORDED_EVENTS+1.

Done.

Also renamed to NUMBER_OF_EVENTS_TO_RECORD
which states better the intention.

[mcasas, 2016-06-29 19:10:28]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-06-29 19:10:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2104643002/#ps100001
(title: "Allow <video>/<audio>.play() for tests when not initiated by user
gesture.")

[commit-bot: I haz the power, 2016-06-29 19:11:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 20:24:09]

Description was changed from

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc, 
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test 
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a 
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data 
flowing.

BUG=619926

TBR=emircan@chromium.org
==========

to

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc, 
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test 
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a 
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data 
flowing.

BUG=619926

TBR=emircan@chromium.org
==========

[commit-bot: I haz the power, 2016-06-29 20:24:10]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-29 20:27:39]

Description was changed from

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc, 
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test 
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a 
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data 
flowing.

BUG=619926

TBR=emircan@chromium.org
==========

to

==========
MediaCaptureFromElement: add content_browsertests

This CL turns webrtc_canvas_capture_browsertest.cc
into webrtc_capture_from_element_browsertest.cc,
(note that they all come out of the same W3C spec).

It also adds a parameterized browser test
CaptureFromMediaElement that creates a MediaStream
out of a given media file played back in a
<video>/<audio> element. The test(s) pass when
there is a certain minimal amount of data
flowing.

BUG=619926

TBR=emircan@chromium.org

Committed: https://crrev.com/c3bfd1da6fa3b657ecd6758a2da4fa09dd983781
Cr-Commit-Position: refs/heads/master@{#402923}
==========

[commit-bot: I haz the power, 2016-06-29 20:27:41]

Patchset 3 (id:??) landed as
https://crrev.com/c3bfd1da6fa3b657ecd6758a2da4fa09dd983781
Cr-Commit-Position: refs/heads/master@{#402923}