third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h - Issue 2104603002: Disable DisplayItemClient aliveness checking when DCHECK is off

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

Issue 2104603002: Disable DisplayItemClient aliveness checking when DCHECK is off (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable DisplayItemClient aliveness checking when DCHECK is off Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

index 4d634751f253a56e42f04063a3bcb055e6e9c9d4..f26f6f96f4683d818bf4fa484248336c472bfea1 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h

@@ -10,9 +10,7 @@

#include "wtf/Assertions.h"

#include "wtf/text/WTFString.h"

-#define CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS 1

-// TODO(wangxianzhu): Restore the following line after we fix crbug.com/609218.

-// #define CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS DCHECK_IS_ON()

+#define CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS DCHECK_IS_ON()

namespace blink {

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | no next file » | no next file with comments »