Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 21046003: Move webstore_private API functions registrations out of ExtensionFunctionRegistry (Closed)

Created:
7 years, 4 months ago by pals
Modified:
7 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move webstore_private API functions registrations out of ExtensionFunctionRegistry BUG=159265 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215005

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -80 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_api.h View 10 chunks +28 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 15 chunks +51 lines, -38 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pals
PTAL. Thanks
7 years, 4 months ago (2013-07-29 10:30:52 UTC) #1
not at google - send to devlin
thanks for splitting this up, need the nocompile though.
7 years, 4 months ago (2013-07-29 14:50:27 UTC) #2
not at google - send to devlin
lgtm
7 years, 4 months ago (2013-07-31 14:53:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/21046003/5001
7 years, 4 months ago (2013-08-01 05:59:02 UTC) #4
commit-bot: I haz the power
7 years, 4 months ago (2013-08-01 11:55:50 UTC) #5
Message was sent while issue was closed.
Change committed as 215005

Powered by Google App Engine
This is Rietveld 408576698