Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1661)

Issue 2104593002: ash: Remove WmShelf::ForPrimaryDisplay (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Remove WmShelf::ForPrimaryDisplay It is unused. I forgot to remove it in https://codereview.chromium.org/2093283002/ BUG=none TEST=compiles R=msw@chromium.org Committed: https://crrev.com/7bf59d5ff61891d483c75644d1a1865e8c959148 Cr-Commit-Position: refs/heads/master@{#402306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M ash/ash.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/shelf/wm_shelf.h View 1 chunk +0 lines, -5 lines 0 comments Download
D ash/common/shelf/wm_shelf.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
James Cook
msw, please take a look
4 years, 5 months ago (2016-06-27 20:33:22 UTC) #3
msw
lgtm
4 years, 5 months ago (2016-06-27 20:46:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104593002/1
4 years, 5 months ago (2016-06-27 21:21:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 21:57:21 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:59:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bf59d5ff61891d483c75644d1a1865e8c959148
Cr-Commit-Position: refs/heads/master@{#402306}

Powered by Google App Engine
This is Rietveld 408576698