Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2104513004: Don't attempt to show validation bubble for unparented web contents. (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, tfarina, noyau+watch_chromium.org, dbeam+watch-downloads_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't attempt to show validation bubble for unparented web contents. This fix is speculative because I can't actually repro the bug. BUG=616990 Committed: https://crrev.com/ba9261ea5d0e1f9a8a29657d8f8fb369d9e9143d Cr-Commit-Position: refs/heads/master@{#402349}

Patch Set 1 #

Patch Set 2 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/browser.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Evan Stade
4 years, 5 months ago (2016-06-27 23:16:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104513004/20001
4 years, 5 months ago (2016-06-27 23:17:32 UTC) #4
sky
LGTM
4 years, 5 months ago (2016-06-27 23:27:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104513004/20001
4 years, 5 months ago (2016-06-27 23:42:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 00:47:24 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 00:50:19 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba9261ea5d0e1f9a8a29657d8f8fb369d9e9143d
Cr-Commit-Position: refs/heads/master@{#402349}

Powered by Google App Engine
This is Rietveld 408576698