Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2104483002: AIX: Update variable name which conflicts with system defined variable (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

AIX: Update variable name which conflicts with system defined variable variable hz is defined as a macro in AIX system header /usr/include/sys/m_param.h (as "ticks per second of the clock"). The pre-processor replaces hz with the numeric value defined in system header file and therefore emits an error. Re-naming variable name to "iz". R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/37538cb2c1b4d75c41af386cb4fedbe5566f5608 Cr-Commit-Position: refs/heads/master@{#37308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/base/ieee754.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-27 17:25:53 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-28 04:38:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104483002/1
4 years, 5 months ago (2016-06-28 04:38:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 05:04:00 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 05:06:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37538cb2c1b4d75c41af386cb4fedbe5566f5608
Cr-Commit-Position: refs/heads/master@{#37308}

Powered by Google App Engine
This is Rietveld 408576698