Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js

Issue 2104473003: Support Windows/Linux-style forward delete feedback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js b/chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js
index 345d6c8e48133427bb2eb132588482246a0d82a4..700da0e319dd2c5d813e8e836cfe8df18f3e046c 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js
@@ -493,9 +493,15 @@ cvox.ChromeVoxEditableTextBase.prototype.describeTextChanged = function(evt) {
evt.start == evtEnd &&
evtValue.substr(0, prefixLen) == value.substr(0, prefixLen) &&
evtValue.substr(newLen - suffixLen) ==
- value.substr(len - suffixLen)) {
- this.describeTextChangedHelper(
- evt, prefixLen, suffixLen, autocompleteSuffix, personality);
+ value.substr(len - suffixLen)) {
+ // Forward deletions causes reading of the character immediately to the
dmazzoni 2016/06/27 22:08:28 Do this only if cvox.ChromeVoxEditableTextBase.use
+ // right of the caret.
+ if (this.start == evt.start && this.end == evt.end) {
+ this.speak(evt.value[evt.start], evt.triggeredByUser);
+ } else {
+ this.describeTextChangedHelper(
+ evt, prefixLen, suffixLen, autocompleteSuffix, personality);
+ }
return;
}
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698