Support Windows/Linux-style forward delete feedback

Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the cursor. This behavior extends to forward deletes. This style of reading is more optimal if one counts the actual cahracters one hears when deleting text assuming the user needs to move to that character first.

By default, this we use this style of reading on Windows, Linux, and Chrome OS based on the ibeam cursor setting.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7eadf9dff59e6e7654ffd9ab3e36c170aacdab97
Cr-Commit-Position: refs/heads/master@{#407954}

[David Tseng, 2016-06-27 20:07:20]

Description was changed from

==========
Fix forward delete feedback.
==========

to

==========
Fix forward delete feedback.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-27 20:08:22]

Description was changed from

==========
Fix forward delete feedback.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix forward delete feedback.

BUG=623370
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-06-27 20:08:22]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-06-27 21:41:55]

Forward-delete gives the correct feedback for me in ChromeVox Classic and Next,
I just tested it. Can you provide any more info on why it sometimes fails for
you?

[dmazzoni, 2016-06-27 22:08:28]

Check the flag and add a unit test

https://codereview.chromium.org/2104473003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js
(right):

https://codereview.chromium.org/2104473003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js:497: //
Forward deletions causes reading of the character immediately to the
Do this only if cvox.ChromeVoxEditableTextBase.useIBeamCursor is false

[David Tseng, 2016-07-26 20:13:57]

Description was changed from

==========
Fix forward delete feedback.

BUG=623370
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-26 20:23:55]

Description was changed from

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes. This style of reading is more
optimal if one counts the actual cahracters one hears when deleting text
assuming the user needs to move to that character first.

By default, this we use this style of reading on Windows, Linux, and Chrome OS
based on the ibeam cursor setting.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-26 20:39:21]

Description was changed from

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes. This style of reading is more
optimal if one counts the actual cahracters one hears when deleting text
assuming the user needs to move to that character first.

By default, this we use this style of reading on Windows, Linux, and Chrome OS
based on the ibeam cursor setting.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes. This style of reading is more
optimal if one counts the actual cahracters one hears when deleting text
assuming the user needs to move to that character first.

By default, this we use this style of reading on Windows, Linux, and Chrome OS
based on the ibeam cursor setting.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-07-26 20:40:59]

PTAL

On 2016/06/27 22:08:28, dmazzoni wrote:
> Check the flag and add a unit test

Ok done.
> 
>
https://codereview.chromium.org/2104473003/diff/1/chrome/browser/resources/ch...
> File chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js
> (right):
> 
>
https://codereview.chromium.org/2104473003/diff/1/chrome/browser/resources/ch...
> chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js:497:
//
> Forward deletions causes reading of the character immediately to the
> Do this only if cvox.ChromeVoxEditableTextBase.useIBeamCursor is false

[dmazzoni, 2016-07-26 22:08:22]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-07-26 22:08:23]

lgtm

[commit-bot: I haz the power, 2016-07-26 22:08:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:08:50]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-26 23:07:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 23:09:47]

Description was changed from

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes. This style of reading is more
optimal if one counts the actual cahracters one hears when deleting text
assuming the user needs to move to that character first.

By default, this we use this style of reading on Windows, Linux, and Chrome OS
based on the ibeam cursor setting.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support Windows/Linux-style forward delete feedback

In Windows and Linux, screen readers read the character to the right of the
cursor. This behavior extends to forward deletes. This style of reading is more
optimal if one counts the actual cahracters one hears when deleting text
assuming the user needs to move to that character first.

By default, this we use this style of reading on Windows, Linux, and Chrome OS
based on the ibeam cursor setting.

BUG=623370
TEST=chromevox_tests --gtest_filter=*Editable*.*
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/7eadf9dff59e6e7654ffd9ab3e36c170aacdab97
Cr-Commit-Position: refs/heads/master@{#407954}
==========

[commit-bot: I haz the power, 2016-07-26 23:09:48]

Patchset 2 (id:??) landed as
https://crrev.com/7eadf9dff59e6e7654ffd9ab3e36c170aacdab97
Cr-Commit-Position: refs/heads/master@{#407954}