Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6731)

Unified Diff: chrome/browser/ui/toolbar/media_router_contextual_menu.cc

Issue 2104463002: [Media Router] Add a context menu item to access the chrome://cast page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/media_router_strings.grdp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/media_router_contextual_menu.cc
diff --git a/chrome/browser/ui/toolbar/media_router_contextual_menu.cc b/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
index d0990e20b8568b7028064e75d5a44c9abf2a2855..fb473c1dc70a14027280650422622becb9421399 100644
--- a/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
+++ b/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
@@ -42,6 +42,8 @@ MediaRouterContextualMenu::MediaRouterContextualMenu(Browser* browser)
menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION,
IDS_EXTENSIONS_UNINSTALL);
menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
+ menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_MANAGE_DEVICES,
+ IDS_MEDIA_ROUTER_MANAGE_DEVICES);
#if defined(GOOGLE_CHROME_BUILD)
menu_model_.AddCheckItemWithStringId(IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE,
IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE);
@@ -99,6 +101,7 @@ void MediaRouterContextualMenu::ExecuteCommand(int command_id,
"https://support.google.com/chromecast/topic/3447927";
const char kCastLearnMorePageUrl[] =
"https://support.google.com/chromecast/answer/2998338";
+ const char kManageCastDevicesUrl[] = "chrome://cast";
#if defined(GOOGLE_CHROME_BUILD)
PrefService* pref_service;
@@ -126,6 +129,9 @@ void MediaRouterContextualMenu::ExecuteCommand(int command_id,
case IDC_MEDIA_ROUTER_LEARN_MORE:
chrome::ShowSingletonTab(browser_, GURL(kCastLearnMorePageUrl));
break;
+ case IDC_MEDIA_ROUTER_MANAGE_DEVICES:
+ chrome::ShowSingletonTab(browser_, GURL(kManageCastDevicesUrl));
apacible 2016/06/27 19:54:56 Do we expect this URL to change in the future? If
sheretov 2016/06/27 20:17:26 Done.
+ break;
case IDC_MEDIA_ROUTER_REMOVE_TOOLBAR_ACTION:
RemoveMediaRouterComponentAction();
break;
« no previous file with comments | « chrome/app/media_router_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698