Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2104453002: Reland of move Android SampleApp (Closed)

Created:
4 years, 5 months ago by rmistry
Modified:
4 years, 5 months ago
Reviewers:
djsollen, liyuqian
CC:
reviews_skia.org, Brian Osman, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of move Android SampleApp (patchset #1 id:1 of https://codereview.chromium.org/2099693002/ ) Reason for revert: Creating reland to test trybot runs.. Original issue's description: > Revert of Remove Android SampleApp (patchset #5 id:80001 of https://codereview.chromium.org/2096683002/ ) > > Reason for revert: > Testing to see if this CL caused the failures in Build-Mac-Clang-Arm7-Debug-Android > > Original issue's description: > > Remove Android SampleApp > > > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2096683002 > > > > Committed: https://skia.googlesource.com/skia/+/41bb5b40e71411ee39538399ea125986ec760a90 > > TBR=djsollen@google.com,liyuqian@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7bde5659d354b4ef227c487a4e9fa8de12573c31 TBR=djsollen@google.com,liyuqian@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1564 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M gyp/everything.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/most.gyp View 1 chunk +4 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D include/views/SkOSWindow_Android.h View 1 chunk +0 lines, -53 lines 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -1 line 0 comments Download
D platform_tools/android/apps/sample_app/build.gradle View 1 chunk +0 lines, -30 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/AndroidManifest.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleActivity.java View 1 chunk +0 lines, -251 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleRenderer.java View 1 chunk +0 lines, -113 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/java/com/skia/SkiaSampleView.java View 1 chunk +0 lines, -310 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/AndroidKeyToSkKey.h View 1 chunk +0 lines, -34 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.h View 1 chunk +0 lines, -164 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp View 1 chunk +0 lines, -356 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_next.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/drawable-hdpi/ic_btn_find_prev.png View Binary file 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/layout/layout.xml View 1 chunk +0 lines, -17 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/menu/action_bar.xml View 1 chunk +0 lines, -75 lines 0 comments Download
D platform_tools/android/apps/sample_app/src/main/res/values/strings.xml View 1 chunk +0 lines, -17 lines 0 comments Download
M platform_tools/android/apps/settings.gradle View 1 chunk +0 lines, -1 line 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
M platform_tools/android/gyp/skia_android.gypi View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmistry
Created Reland of move Android SampleApp
4 years, 5 months ago (2016-06-27 16:19:47 UTC) #1
rmistry
On 2016/06/27 16:19:47, rmistry wrote: > Created Reland of move Android SampleApp The trybot here ...
4 years, 5 months ago (2016-06-27 16:55:50 UTC) #2
rmistry
On 2016/06/27 16:55:50, rmistry wrote: > On 2016/06/27 16:19:47, rmistry wrote: > > Created Reland ...
4 years, 5 months ago (2016-06-27 18:04:11 UTC) #3
rmistry
4 years, 5 months ago (2016-06-28 11:53:23 UTC) #5
On 2016/06/27 18:04:11, rmistry wrote:
> On 2016/06/27 16:55:50, rmistry wrote:
> > On 2016/06/27 16:19:47, rmistry wrote:
> > > Created Reland of move Android SampleApp
> > 
> > The trybot here failed as expected.
> > 
> > I will now try wiping out the
> > /b/work/skia/out/Build-Mac-Clang-Arm7-Debug-Android-Trybot directory on the
5
> > bots listed here:
> >
>
https://chromium-swarm.appspot.com/restricted/bots?dimensions=pool%3ASkia%0D%...
> 
> The trybot run failed on vm692-m3 even after I cleaned the out directories:
> https://chromium-swarm.appspot.com/user/task/2fabaa5922cf3010
> 
> Looks like we need another solution.

liyuqian@ replied: I wonder if there's anything that I can try locally on my mac
pro?

The swarming task: https://chromium-swarm.appspot.com/user/task/2fabaa5922cf3010
Has the dimensions of the machine the task ran on under "Bot dimensions".
Also, you can run the same task locally by following instructions on that page
under "Run this task locally:".

+Eric in case he has additional suggestions.

Powered by Google App Engine
This is Rietveld 408576698