Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2104423002: Stop using UMA preference to gate sending HitReport to SB backend. (Closed)

Created:
4 years, 5 months ago by Jialiu Lin
Modified:
4 years, 5 months ago
Reviewers:
Nathan Parker
CC:
awoz, chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using UMA preference to gate sending HitReport to SB backend, use extended reporting preference instead. BUG=598889 Committed: https://crrev.com/b027a7b5aa954ab83d9b5b591ba98d019c4fbc22 Cr-Commit-Position: refs/heads/master@{#403302}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Keep is_metrics_reporting_active #

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Jialiu Lin
Hi Alex, Could you take a look at this CL? I don't know if removing ...
4 years, 5 months ago (2016-06-29 19:19:19 UTC) #2
Jialiu Lin
Hi nparker@, I have confirmed with awoz@ that this CL does not require any server ...
4 years, 5 months ago (2016-06-30 18:05:10 UTC) #5
Nathan Parker
I'm wondering if we want to remove the UMA bit from the reports. The only ...
4 years, 5 months ago (2016-06-30 18:37:34 UTC) #6
Jialiu Lin
Based on our discussion in person, keep is_metric_reporting_active bit.
4 years, 5 months ago (2016-06-30 20:41:03 UTC) #7
Nathan Parker
lgtm
4 years, 5 months ago (2016-06-30 20:53:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104423002/60001
4 years, 5 months ago (2016-06-30 20:56:38 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-30 21:45:57 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:47:41 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b027a7b5aa954ab83d9b5b591ba98d019c4fbc22
Cr-Commit-Position: refs/heads/master@{#403302}

Powered by Google App Engine
This is Rietveld 408576698