ppapi/proxy/ppb_graphics_3d_proxy.h - Issue 2104403003: pepper: parse context creation attrib list on the plugin side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppb_graphics_3d_proxy.h

Issue 2104403003: pepper: parse context creation attrib list on the plugin side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gpu_pref_size_in_attrs

Patch Set: moar gyp fickses Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppb_graphics_3d_proxy.h

diff --git a/ppapi/proxy/ppb_graphics_3d_proxy.h b/ppapi/proxy/ppb_graphics_3d_proxy.h

index 2a28fce80b8d239ecf917439c8b4380caa53bc0c..fc96a2e815d53790b92b5fbbe97494d562f83544 100644

--- a/ppapi/proxy/ppb_graphics_3d_proxy.h

+++ b/ppapi/proxy/ppb_graphics_3d_proxy.h

@@ -22,6 +22,9 @@

#include "ppapi/utility/completion_callback_factory.h"

namespace gpu {

+namespace gles2 {

+struct ContextCreationAttribHelper;

struct Capabilities;

}

@@ -86,7 +89,7 @@ class PPB_Graphics3D_Proxy : public InterfaceProxy {

private:

void OnMsgCreate(PP_Instance instance,

HostResource share_context,

- const std::vector<int32_t>& attribs,

+ const gpu::gles2::ContextCreationAttribHelper& attrib_helper,

HostResource* result,

gpu::Capabilities* capabilities,

SerializedHandle* handle,

« no previous file with comments | « ppapi/proxy/ppapi_messages.h ('k') | ppapi/proxy/ppb_graphics_3d_proxy.cc » ('j') | ui/gfx/gfx_geometry.gypi » ('J')