Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: content/renderer/pepper/ppb_graphics_3d_impl.h

Issue 2104403003: pepper: parse context creation attrib list on the plugin side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gpu_pref_size_in_attrs
Patch Set: moar gyp fickses Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/ppb_graphics_3d_impl.h
diff --git a/content/renderer/pepper/ppb_graphics_3d_impl.h b/content/renderer/pepper/ppb_graphics_3d_impl.h
index abafd2c4b14bd0eaf87ca780c0f5e42d315e0ad9..e9615a2768c92cd5ac7adaeaeda1ad9267b01262 100644
--- a/content/renderer/pepper/ppb_graphics_3d_impl.h
+++ b/content/renderer/pepper/ppb_graphics_3d_impl.h
@@ -20,6 +20,9 @@
#include "ppapi/shared_impl/resource.h"
namespace gpu {
+namespace gles2 {
+struct ContextCreationAttribHelper;
+}
struct Capabilities;
class CommandBufferProxyImpl;
}
@@ -29,12 +32,13 @@ namespace content {
class PPB_Graphics3D_Impl : public ppapi::PPB_Graphics3D_Shared,
public gpu::GpuControlClient {
public:
- static PP_Resource CreateRaw(PP_Instance instance,
- PP_Resource share_context,
- const int32_t* attrib_list,
- gpu::Capabilities* capabilities,
- base::SharedMemoryHandle* shared_state_handle,
- gpu::CommandBufferId* command_buffer_id);
+ static PP_Resource CreateRaw(
+ PP_Instance instance,
+ PP_Resource share_context,
+ const gpu::gles2::ContextCreationAttribHelper& attrib_helper,
+ gpu::Capabilities* capabilities,
+ base::SharedMemoryHandle* shared_state_handle,
+ gpu::CommandBufferId* command_buffer_id);
// PPB_Graphics3D_API trusted implementation.
PP_Bool SetGetBuffer(int32_t transfer_buffer_id) override;
@@ -76,7 +80,7 @@ class PPB_Graphics3D_Impl : public ppapi::PPB_Graphics3D_Shared,
explicit PPB_Graphics3D_Impl(PP_Instance instance);
bool InitRaw(PPB_Graphics3D_API* share_context,
- const int32_t* attrib_list,
+ const gpu::gles2::ContextCreationAttribHelper& attrib_helper,
gpu::Capabilities* capabilities,
base::SharedMemoryHandle* shared_state_handle,
gpu::CommandBufferId* command_buffer_id);

Powered by Google App Engine
This is Rietveld 408576698