Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 2104393003: Revert of Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer. (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
Reviewers:
erikchen, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer. (patchset #2 id:20001 of https://codereview.chromium.org/2106843002/ ) Reason for revert: Broke 3d transforms, see: https://crbug.com/624256 Original issue's description: > Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer. > > Create an enum class Type in GLImage, which allows for safe downcasting. > > BUG=619698 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/ccd5fbaca5867773830b38ea64c2a79f932f6478 > Cr-Commit-Position: refs/heads/master@{#402582} TBR=piman@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=619698, 624256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -45 lines) Patch
M gpu/ipc/service/image_transport_surface_overlay_mac.mm View 3 chunks +12 lines, -18 lines 0 comments Download
M ui/gl/gl_image.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gl/gl_image.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pdr.
Created Revert of Remove unsafe cast from ImageTransportSurfaceOverlayMac::ScheduleCALayer.
4 years, 5 months ago (2016-06-30 00:04:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104393003/1
4 years, 5 months ago (2016-06-30 00:05:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 01:24:45 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 01:26:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6429905f0b03788c5d6a4280f2a415c93e12c0b
Cr-Commit-Position: refs/heads/master@{#403055}

Powered by Google App Engine
This is Rietveld 408576698