Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revised histogram naming from OfflinerStatus to OfflinerRequestStatus Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 314ea0693beb27552e17d7d0479b5d9816860d6f..b1c88161bf55b87bd9a3f69524c06e5990ea62a0 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -84,8 +84,8 @@ class OfflinerStub : public Offliner {
// Clears the currently processing request, if any.
void Cancel() override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(callback_, request_, Offliner::RequestStatus::CANCELED));
+ FROM_HERE, base::Bind(callback_, request_,
+ Offliner::RequestStatus::LOAD_CANCELED));
}
void enable_callback(bool enable) {
@@ -100,7 +100,6 @@ class OfflinerStub : public Offliner {
class OfflinerFactoryStub : public OfflinerFactory {
public:
-
OfflinerFactoryStub() : offliner_(nullptr) {}
Offliner* GetOffliner(const OfflinerPolicy* policy) override {
@@ -132,7 +131,7 @@ class RequestCoordinatorTest
return coordinator_->is_busy();
}
- void SendRequestToOffliner(SavePageRequest& request) {
+ void SendRequestToOffliner(const SavePageRequest& request) {
coordinator_->SendRequestToOffliner(request);
}
@@ -335,7 +334,7 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailed) {
// Call the OfflinerDoneCallback to simulate the request failed, wait
// for callbacks.
EnableOfflinerCallback(true);
- SendOfflinerDoneCallback(request, Offliner::RequestStatus::FAILED);
+ SendOfflinerDoneCallback(request, Offliner::RequestStatus::LOAD_FAILED);
PumpLoop();
// Verify the request is not removed from the queue, and wait for callbacks.
@@ -413,7 +412,7 @@ TEST_F(RequestCoordinatorTest, StartProcessingThenStopProcessingLater) {
// OfflinerDoneCallback will not end up getting called with status SAVED,
// Since we cancelled the event before it called offliner_->LoadAndSave().
- EXPECT_EQ(Offliner::RequestStatus::CANCELED, last_offlining_status());
+ EXPECT_EQ(Offliner::RequestStatus::LOAD_CANCELED, last_offlining_status());
}
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698