Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rename in unittest (from merge). Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index 0204b1b8cd932c56d7800680a08181e0af37b52a..1d8884569dd2bc57be064d4cd61243dbd986250c 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -89,8 +89,8 @@ class OfflinerStub : public Offliner {
// Clears the currently processing request, if any.
void Cancel() override {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(callback_, request_, Offliner::RequestStatus::CANCELED));
+ FROM_HERE, base::Bind(callback_, request_,
+ Offliner::RequestStatus::PRERENDERING_CANCELED));
}
void enable_callback(bool enable) {
@@ -105,7 +105,6 @@ class OfflinerStub : public Offliner {
class OfflinerFactoryStub : public OfflinerFactory {
public:
-
OfflinerFactoryStub() : offliner_(nullptr) {}
Offliner* GetOffliner(const OfflinerPolicy* policy) override {
@@ -356,7 +355,8 @@ TEST_F(RequestCoordinatorTest, OfflinerDoneRequestFailed) {
// Call the OfflinerDoneCallback to simulate the request failed, wait
// for callbacks.
EnableOfflinerCallback(true);
- SendOfflinerDoneCallback(request, Offliner::RequestStatus::FAILED);
+ SendOfflinerDoneCallback(request,
+ Offliner::RequestStatus::PRERENDERING_FAILED);
PumpLoop();
// Verify the request is not removed from the queue, and wait for callbacks.
@@ -434,7 +434,8 @@ TEST_F(RequestCoordinatorTest, StartProcessingThenStopProcessingLater) {
// OfflinerDoneCallback will not end up getting called with status SAVED,
// Since we cancelled the event before it called offliner_->LoadAndSave().
- EXPECT_EQ(Offliner::RequestStatus::CANCELED, last_offlining_status());
+ EXPECT_EQ(Offliner::RequestStatus::PRERENDERING_CANCELED,
+ last_offlining_status());
}
TEST_F(RequestCoordinatorTest, PrerendererTimeout) {
@@ -478,7 +479,8 @@ TEST_F(RequestCoordinatorTest, PrerendererTimeout) {
PumpLoop();
// Now trying to start processing on another request should return false.
- EXPECT_EQ(Offliner::RequestStatus::CANCELED, last_offlining_status());
+ EXPECT_EQ(Offliner::RequestStatus::REQUEST_COORDINATOR_CANCELED,
+ last_offlining_status());
}
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698