chrome/browser/android/offline_pages/prerendering_loader_unittest.cc - Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

Issue 2104393002: Adds UMA for PrerenderingOffliner request processing result status. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_loader.cc ('k') | chrome/browser/android/offline_pages/prerendering_offliner.cc » ('j') | components/offline_pages/background/offliner.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

index d7f28d9f43fad5fff6b6f6b5370fd9f0b6cf2b01..20cfd4ce63ecfb9ce71ba31e013e185f5816df8e 100644

--- a/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

+++ b/chrome/browser/android/offline_pages/prerendering_loader_unittest.cc

@@ -223,7 +223,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadSucceededFromPrerenderStopLoading) {

PumpLoop();

EXPECT_TRUE(loader()->IsIdle());

EXPECT_FALSE(loader()->IsLoaded());

- EXPECT_EQ(Offliner::RequestStatus::CANCELED, callback_load_status());

+ EXPECT_EQ(Offliner::RequestStatus::LOAD_CANCELED, callback_load_status());

}

TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {

@@ -243,7 +243,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadFailedNoContent) {

EXPECT_TRUE(loader()->IsIdle());

EXPECT_TRUE(callback_called());

// We did not provide any WebContents for the callback so expect did not load.

- EXPECT_EQ(Offliner::RequestStatus::FAILED, callback_load_status());

+ EXPECT_EQ(Offliner::RequestStatus::LOAD_FAILED, callback_load_status());

// Stopped event causes no harm.

test_adapter()->GetObserver()->OnPrerenderStop();

@@ -263,7 +263,7 @@ TEST_F(PrerenderingLoaderTest, LoadPageLoadCanceledFromStopLoading) {

PumpLoop();

EXPECT_TRUE(loader()->IsIdle());

EXPECT_TRUE(callback_called());

- EXPECT_EQ(Offliner::RequestStatus::CANCELED, callback_load_status());

+ EXPECT_EQ(Offliner::RequestStatus::LOAD_CANCELED, callback_load_status());

}

TEST_F(PrerenderingLoaderTest, LoadPageNotAcceptedWhenNotIdle) {