Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 2104383002: Avoid using a cast for a overload selection (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 5 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews, darin-cc_chromium.org, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid using a cast for a overload selection This is a workaround of clang-win bot crash: https://llvm.org/bugs/show_bug.cgi?id=28360 BUG=554299 Committed: https://crrev.com/cd1b45a5798a8d6a990b480cc4971de09079d361 Cr-Commit-Position: refs/heads/master@{#403083}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase to land #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/indexed_db/indexed_db_unittest.cc View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
tzik
PTAL
4 years, 5 months ago (2016-06-29 16:34:24 UTC) #3
cmumford
lgtm
4 years, 5 months ago (2016-06-29 20:14:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104383002/40001
4 years, 5 months ago (2016-06-30 02:49:32 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 03:49:03 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cd1b45a5798a8d6a990b480cc4971de09079d361 Cr-Commit-Position: refs/heads/master@{#403083}
4 years, 5 months ago (2016-06-30 03:51:43 UTC) #11
jsbell
4 years, 5 months ago (2016-07-07 16:49:05 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2104383002/diff/40001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_unittest.cc (right):

https://codereview.chromium.org/2104383002/diff/40001/content/browser/indexed...
content/browser/indexed_db/indexed_db_unittest.cc:249: // TODO(jsbell): Remove
static_cast<> when overloads are eliminated.
Would have been nice to eliminate the comment too. :) Follow-up?

Powered by Google App Engine
This is Rietveld 408576698