chrome/test/chromedriver/server/chromedriver_server.cc - Issue 2104363004: Remove remaining calls to deprecated MessageLoop methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/chromedriver_server.cc

Issue 2104363004: Remove remaining calls to deprecated MessageLoop methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CR gab Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | components/autofill/core/browser/personal_data_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/server/chromedriver_server.cc

diff --git a/chrome/test/chromedriver/server/chromedriver_server.cc b/chrome/test/chromedriver/server/chromedriver_server.cc

index 3146c31af9a59ffefdc765668e886e0bac3e428a..79d25fc4d70e150b6ba5c34f5d771d46b0da9b00 100644

--- a/chrome/test/chromedriver/server/chromedriver_server.cc

+++ b/chrome/test/chromedriver/server/chromedriver_server.cc

@@ -22,6 +22,7 @@

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

#include "base/run_loop.h"

+#include "base/single_thread_task_runner.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_split.h"

#include "base/strings/string_util.h"

@@ -207,7 +208,7 @@ void RunServer(uint16_t port,

HttpRequestHandlerFunc handle_request_func =

base::Bind(&HandleRequestOnCmdThread, &handler, whitelisted_ips);

- io_thread.message_loop()->PostTask(

+ io_thread.message_loop()->task_runner()->PostTask(

FROM_HERE,

base::Bind(&StartServerOnIOThread, port, allow_remote,

base::Bind(&HandleRequestOnIOThread, cmd_loop.task_runner(),

@@ -218,8 +219,8 @@ void RunServer(uint16_t port,

// destroyed, which waits until all pending tasks have been completed.

// This assumes the response is sent synchronously as part of the IO task.

cmd_run_loop.Run();

- io_thread.message_loop()

- ->PostTask(FROM_HERE, base::Bind(&StopServerOnIOThread));

+ io_thread.message_loop()->task_runner()->PostTask(

+ FROM_HERE, base::Bind(&StopServerOnIOThread));

}

} // namespace