Issue 2104333002: Ensure short path names for generated tests on Windows, in test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2104333002: Ensure short path names for generated tests on Windows, in test runner. (Closed)

Created:
4 years, 5 months ago by Bill Hesse

Modified:
4 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Ensure short path names for generated tests on Windows, in test runner. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/3d9f53a4e663f537c061205fdf65afbd6d3e3acd

Patch Set 1 #

Total comments: 1

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		3 chunks	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Søren Gjesse

lgtm https://codereview.chromium.org/2104333002/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/2104333002/diff/1/tools/testing/dart/test_suite.dart#newcode2474 tools/testing/dart/test_suite.dart:2474: path = "short${shortNameCounter}_$pathEnd"; Maybe add __ in front ...

4 years, 5 months ago (2016-06-29 15:35:56 UTC) #3

Bill Hesse

4 years, 5 months ago (2016-06-29 20:43:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d9f53a4e663f537c061205fdf65afbd6d3e3acd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages