Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4415)

Unified Diff: chromeos/network/favorite_state.h

Issue 210433002: Always list EthernetEAP as a Favorite for debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/network/favorite_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/favorite_state.h
diff --git a/chromeos/network/favorite_state.h b/chromeos/network/favorite_state.h
index 075bc04ab967729c2ffccdd752a23e2a66bb6b20..bb468a76e9aaca98d74a333d844af5fdbd7eb968 100644
--- a/chromeos/network/favorite_state.h
+++ b/chromeos/network/favorite_state.h
@@ -20,7 +20,7 @@ namespace chromeos {
// Note: NetworkStateHandler will store an entry for each member of
// Manager.ServiceCompleteList, even for visible entries that are not
// favorites. This is necessary to avoid unnecessarily re-requesting entries,
-// and to limit the code complexity. The is_favorite() accessor is used to skip
+// and to limit the code complexity. The IsFavorite() accessor is used to skip
// entries that are not actually favorites.
class CHROMEOS_EXPORT FavoriteState : public ManagedState {
public:
@@ -33,12 +33,14 @@ class CHROMEOS_EXPORT FavoriteState : public ManagedState {
// Accessors
const std::string& profile_path() const { return profile_path_; }
- bool is_favorite() const { return !profile_path_.empty(); }
const NetworkUIData& ui_data() const { return ui_data_; }
const base::DictionaryValue& proxy_config() const { return proxy_config_; }
const std::string& guid() const { return guid_; }
const base::DictionaryValue& properties() const { return properties_; }
+ // Returns true if this is a favorite stored in a profile (see note above).
+ bool IsFavorite() const;
+
// Returns true if the network properties are stored in a user profile.
bool IsPrivate() const;
« no previous file with comments | « no previous file | chromeos/network/favorite_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698