Always list EthernetEAP as a Favorite for debugging

Always list EthernetEAP as a Favorite for debugging

Because EthernetEAP is never a visible service, we do not observe it.
When it is first created, no properties (including Profile) are set, so
it does not appear in the 'Favorite' list and as a result never gets
updated. This currently only affects debugging.

As a workaround, we always treat EthernetEAP networks as a Favorite,
eveb if Profile is empty.

BUG=355117
R=pneubeck@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259682

[pneubeck (no reviews), 2014-03-25 10:46:06]

Could you instead try replacing network_list_ by favorite_list_ in
NetworkStateHandler::ProfileListChanged ?

[stevenjb, 2014-03-25 18:41:17]

On 2014/03/25 10:46:06, pneubeck wrote:
> Could you instead try replacing network_list_ by favorite_list_ in
> NetworkStateHandler::ProfileListChanged ?
Good call, that helps, done. I removed the explicit
'RequestUpdateForAllNetworks' so that it doesn't affect properties for
debugging.

[pneubeck (no reviews), 2014-03-26 02:45:21]

I hoped that this would also make the change to IsFavorite unnecessary. Please
revert that if so.

If it's still required, lgtm.

[stevenjb, 2014-03-26 16:58:25]

On 2014/03/26 02:45:21, pneubeck wrote:
> I hoped that this would also make the change to IsFavorite unnecessary. Please
> revert that if so.
> 
> If it's still required, lgtm.

I considered removing that change, but decided that it would be better to leave
that in; I don't want to rely on receiving a ProfileListChanged signal to show
EAP properties if they exist. The logic is still sound - EAP services are a
special case in that they are never "visible" even though their properties may
be relevant.

[stevenjb, 2014-03-26 16:58:30]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-03-26 16:59:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/210433002/40001

[commit-bot: I haz the power, 2014-03-26 20:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-26 20:13:48]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[stevenjb, 2014-03-26 20:56:01]

Committed patchset #4 manually as r259682 (presubmit successful).

[erikchen, 2014-03-26 22:00:06]

A revert of this CL has been created in
https://codereview.chromium.org/212953010/ by erikchen@chromium.org.

The reason for reverting is: chrome_os unittest failures:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....