Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 2104303003: Disable PathOpsFailOp test for Bazel ASAN. (Closed)

Created:
4 years, 5 months ago by dogben
Modified:
4 years, 5 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable PathOpsFailOp test for Bazel ASAN test, because there are double->float cast overflows in PathOps code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104303003 Committed: https://skia.googlesource.com/skia/+/b5188624f6bd6015166ae6898bbc35f19f7d94bb

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104303003/20001
4 years, 5 months ago (2016-06-29 17:08:12 UTC) #3
dogben
4 years, 5 months ago (2016-06-29 17:09:25 UTC) #6
caryclark
On 2016/06/29 17:09:25, Ben Wagner wrote: Can you point me to the overflows or how ...
4 years, 5 months ago (2016-06-29 17:13:59 UTC) #7
caryclark
lgtm (to get past the ASAN failure)
4 years, 5 months ago (2016-06-29 17:15:00 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 17:24:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104303003/20001
4 years, 5 months ago (2016-06-29 17:25:33 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 17:26:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b5188624f6bd6015166ae6898bbc35f19f7d94bb

Powered by Google App Engine
This is Rietveld 408576698