Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: tracing/tracing/metrics/v8/v8_metrics.html

Issue 2104303002: Create a metric that combines v8, memory, and responsiveness metrics. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: revert discrepancy metric change Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/v8/v8_metrics.html
diff --git a/tracing/tracing/metrics/v8/v8_metrics.html b/tracing/tracing/metrics/v8/v8_metrics.html
index 1fa6934449430dd9e86eef457bb95dd03f7d1129..03e705233351c246985c71b8ebe270d8671ae12a 100644
--- a/tracing/tracing/metrics/v8/v8_metrics.html
+++ b/tracing/tracing/metrics/v8/v8_metrics.html
@@ -7,6 +7,7 @@ found in the LICENSE file.
<link rel="import" href="/tracing/metrics/metric_registry.html">
<link rel="import" href="/tracing/metrics/system_health/memory_metric.html">
+<link rel="import" href="/tracing/metrics/system_health/responsiveness_metric.html">
<link rel="import" href="/tracing/metrics/v8/execution_metric.html">
<link rel="import" href="/tracing/metrics/v8/gc_metric.html">
@@ -20,10 +21,19 @@ tr.exportTo('tr.metrics.v8', function() {
tr.metrics.sh.memoryMetric(values, model);
}
+ // TODO(ulan): Remove this uber-metric once metric_runner supports multiple
+ // TBMv2 metics (https://github.com/catapult-project/catapult/issues/2430).
+ function v8AndMemoryAndResponsivenessMetrics(values, model) {
+ v8AndMemoryMetrics(values, model);
+ tr.metrics.sh.responsivenessMetric(values, model);
+ }
+
tr.metrics.MetricRegistry.register(v8AndMemoryMetrics);
+ tr.metrics.MetricRegistry.register(v8AndMemoryAndResponsivenessMetrics);
return {
- v8AndMemoryMetrics: v8AndMemoryMetrics
+ v8AndMemoryMetrics: v8AndMemoryMetrics,
+ v8AndMemoryAndResponsivenessMetrics: v8AndMemoryAndResponsivenessMetrics
};
});
</script>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698