Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2104283002: Tidy CrossThreadCopier.h inclusion. (Closed)

Created:
4 years, 5 months ago by sof
Modified:
4 years, 5 months ago
Reviewers:
hiroshige, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy CrossThreadCopier.h inclusion. This header file declares a set of types as being cross-copiable; avoid bringing in all of Oilpan for its two cross-thread persistent types. Tidy up some downstream header files which were implicitly depending on Oilpan being included here. R= BUG=597856, 624419 Committed: https://crrev.com/f2b88d1e91a969a91bc4ca9bdebb4dd1bd0edfdd Cr-Commit-Position: refs/heads/master@{#402823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
sof
just something noticed while looking at r402738 - not sure it is worth it. CrossThreadCopier.h ...
4 years, 5 months ago (2016-06-29 11:02:07 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-06-29 11:39:42 UTC) #4
hiroshige
lgtm! > CrossThreadCopier.h could now be moved to wtf/, if that's a goal. It would ...
4 years, 5 months ago (2016-06-29 14:35:25 UTC) #5
sof
On 2016/06/29 14:35:25, hiroshige wrote: > lgtm! > > > CrossThreadCopier.h could now be moved ...
4 years, 5 months ago (2016-06-29 14:41:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104283002/1
4 years, 5 months ago (2016-06-29 14:41:43 UTC) #8
hiroshige
Created Issue 624419 for tracking move of CrossThreadCopier. Could you add it to BUG= field ...
4 years, 5 months ago (2016-06-29 14:44:30 UTC) #9
sof
On 2016/06/29 14:44:30, hiroshige wrote: > Created Issue 624419 for tracking move of CrossThreadCopier. Could ...
4 years, 5 months ago (2016-06-29 14:46:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104283002/1
4 years, 5 months ago (2016-06-29 14:46:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 15:54:29 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 15:57:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2b88d1e91a969a91bc4ca9bdebb4dd1bd0edfdd
Cr-Commit-Position: refs/heads/master@{#402823}

Powered by Google App Engine
This is Rietveld 408576698