Issue 2104233004: [Mac][Material Design] Use white tab spinner for dark themes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2104233004: [Mac][Material Design] Use white tab spinner for dark themes. (Closed)

Created:
4 years, 5 months ago by shrike

Modified:
4 years, 5 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Mac][Material Design] Use white tab spinner for dark themes. In Material Design we display a white tab spinner for Incognito mode tabs, but we need to also do so for dark themes. R=avi@chromium.org BUG=624106 Review-Url: https://codereview.chromium.org/2103073003 Cr-Commit-Position: refs/heads/master@{#402643} (cherry picked from commit f61958a3d0125bc8848164c5dc6157e2c08738ae)

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

shrike

4 years, 5 months ago (2016-07-20 20:35:38 UTC) #1

Description was changed from

==========
[Mac][Material Design] Use white tab spinner for dark themes.

In Material Design we display a white tab spinner for Incognito mode
tabs, but we need to also do so for dark themes.

R=avi@chromium.org
BUG=624106

Review-Url: https://codereview.chromium.org/2103073003
Cr-Commit-Position: refs/heads/master@{#402643}
(cherry picked from commit f61958a3d0125bc8848164c5dc6157e2c08738ae)
==========

to

==========
[Mac][Material Design] Use white tab spinner for dark themes.

In Material Design we display a white tab spinner for Incognito mode
tabs, but we need to also do so for dark themes.

R=avi@chromium.org
BUG=624106

Review-Url: https://codereview.chromium.org/2103073003
Cr-Commit-Position: refs/heads/master@{#402643}
(cherry picked from commit f61958a3d0125bc8848164c5dc6157e2c08738ae)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages