Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: pkg/compiler/lib/src/dart2js.dart

Issue 2104233003: Fix and tests command line options (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/command_line_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/dart2js.dart
diff --git a/pkg/compiler/lib/src/dart2js.dart b/pkg/compiler/lib/src/dart2js.dart
index b82ad535387d5ae5c7e9a48398246c9700e7f365..f07af9d1b28d4a5e2743dbc529809f29f80245e3 100644
--- a/pkg/compiler/lib/src/dart2js.dart
+++ b/pkg/compiler/lib/src/dart2js.dart
@@ -471,7 +471,8 @@ Future<api.CompilationResult> compile(List<String> argv) {
api.Diagnostic.INFO);
}
if (resolveOnly) {
- if (resolutionInputs.contains(resolutionOutput)) {
+ if (resolutionInputs != null &&
+ resolutionInputs.contains(resolutionOutput)) {
helpAndFail("Resolution input '${resolutionOutput}' can't be used as "
"resolution output. Use the '--out' option to specify another "
"resolution output.");
@@ -535,7 +536,7 @@ Future<api.CompilationResult> compile(List<String> argv) {
packageConfig: packageConfig,
packagesDiscoveryProvider: findPackages,
resolutionInputs: resolutionInputs,
- resolutionOutput: resolutionOutput,
+ resolutionOutput: resolveOnly ? resolutionOutput: null,
options: options,
environment: environment);
return compileFunc(
« no previous file with comments | « no previous file | tests/compiler/dart2js/command_line_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698